-
Notifications
You must be signed in to change notification settings - Fork 6
Enable CHIPS - partitioned auth cookie for 3rd party use #3258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe session cookie configuration in the Changes
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/core/config/config.service.ts (1)
288-290
: Add tests covering thepartitioned
cookie option.
We should add unit or integration tests to confirm thatsessionCookie
correctly emitspartitioned: true
in non-Safari/dev environments and respects the Safari/dev override.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/core/config/config.service.ts
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: E2E Tests (neo4j 4/6)
- GitHub Check: E2E Tests (neo4j 1/6)
- GitHub Check: Generate (base)
- GitHub Check: Generate (head)
- GitHub Check: E2E Tests (neo4j 3/6)
- GitHub Check: E2E Tests (neo4j 6/6)
- GitHub Check: E2E Tests (neo4j 5/6)
- GitHub Check: E2E Tests (neo4j 2/6)
- GitHub Check: Unit
- GitHub Check: lint
- GitHub Check: Clean
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
src/core/config/config.service.ts (2)
288-290
: Ensurepartitioned
is declared onCookieOptions
.
Thepartitioned
flag must be part of theCookieOptions
interface from../http
—otherwise TypeScript will error or silently strip the option. Please confirm or extend the interface to includepartitioned: boolean
.
288-290
: Verify browser support for CHIPS.
Partitioned cookies (CHIPS) are only supported in Chromium-based browsers. Ensure unsupported browsers fall back gracefully or that you’ve implemented feature detection before applying this flag.
No description provided.